doc: updating Ninja guide #32629
Closed
doc: updating Ninja guide #32629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvelezpo
approved these changes
Apr 3, 2020
sam-github
approved these changes
Apr 3, 2020
gengjiawen
reviewed
Apr 3, 2020
mmarchini
reviewed
Apr 3, 2020
edsadr
force-pushed
the
edsadr/ninja-guide
branch
from
76e0c55
to
4ebde3f
Compare
addaleax
approved these changes
Apr 5, 2020
Trott
reviewed
Apr 5, 2020
Trott
reviewed
Apr 5, 2020
Trott
reviewed
Apr 5, 2020
Trott
reviewed
Apr 5, 2020
Trott
approved these changes
Apr 5, 2020
gengjiawen
approved these changes
Apr 6, 2020
edsadr
force-pushed
the
edsadr/ninja-guide
branch
from
4ebde3f
to
b975185
Compare
|
Thanks for the review and the amazing suggestions @Trott , I just applied them and I guess this is ready :) |
|
Landed in fd2b35c |
Trott
pushed a commit
that referenced
this pull request
Apr 6, 2020
PR-URL: #32629 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
PR-URL: #32629 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
PR-URL: #32629 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32629 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the guide to use Ninja, because the instructions were outdated after merging this PR
make -j4 test(UNIX), orvcbuild test(Windows) passes