http: fixup options.method error message #32471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
fixup-error-message-http-client
branch
from
068e55d to
1e861a9
Compare
Use `options.method` instead of just `method` Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
fixup-error-message-http-client
branch
from
1e861a9 to
59bf960
Compare
Collaborator
evanlucas
approved these changes
Mar 25, 2020
Collaborator
jasnell
added
the
author ready
trivikr
approved these changes
Mar 27, 2020
Member
|
Landed in ca19d55 |
addaleax
pushed a commit
that referenced
this pull request
Mar 27, 2020
Use `options.method` instead of just `method` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32471 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
Use `options.method` instead of just `method` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32471 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Use `options.method` instead of just `method` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32471 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
options.methodinstead of justmethodin ERR_INVALID_ARG_TYPEChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes