Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: enhance template function 'MakeUtf8String' #32322

Closed
wants to merge 1 commit into from
Closed

src: enhance template function 'MakeUtf8String' #32322

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

for better code highlighting

image

image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 17, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29962/ (:yellow_heart:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 29, 2020
@himself65 @addaleax
src: enhance template function 'MakeUtf8String'
a246312 
PR-URL: #32322
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@addaleax
Copy link
Member

Landed in a246312

@addaleax addaleax closed this Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@himself65 @addaleax
src: enhance template function 'MakeUtf8String'
b973b93 
PR-URL: #32322
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@himself65 @targos
src: enhance template function 'MakeUtf8String'
c9b22c8 
PR-URL: #32322
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himself65 @nodejs-github-bot @addaleax @jasnell @devsnek