net: don't explicitly set readable/writable#32271
Closed
ronag wants to merge 1 commit into
Closed
Conversation
ronag
force-pushed
the
net-stream-writable-readable
branch
from
March 14, 2020 21:46
d810373 to
0866ef1
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net.Socketis slightly breaking stream invariants by having readable/writable going fromfalsetotrue. Streams assume that readable/writable starts outtrueand then goes tofalsethroughpush(null)/end()after which it never goes back totrue, e.g. once a stream iswritable == falseit is assumed it will never becometrue.This PR changes 2 things:
Unless explicitly set to
falsethrough options:readable/writabletrueby default.push(null)/end()to setreadable/writabletofalse. Note that this would cause the socket to emit the'end'/'finish'events, which it did not do previously.In the case it is explicitly set to
falsethroughoptionsit is assumed to never becometrue.This makes
netbehave like regular streams and the way quic currently handles the corresponding functionality.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes