Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-timers-blocking-callback flaky on osx #32189

Closed
wants to merge 1 commit into from
Closed

test: mark test-timers-blocking-callback flaky on osx #32189

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

This is only for 10.15 but this test is periodically failing across
many CI runs. Would like to mark this as flaky so we can avoid lots
of red CI.

Refs: #21781

@MylesBorins
test: mark test-timers-blocking-callback flaky on osx
3b9d565 
This is only for 10.15 but this test is periodically failing across
many CI runs. Would like to mark this as flaky so we can avoid lots
of red CI.

Refs: nodejs#21781
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 11, 2020
@MylesBorins
Copy link
Contributor Author

Can I get a fastrack? this is going to block 13.11.0

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2020
@MylesBorins
Copy link
Contributor Author

landed in e00e77e

MylesBorins added a commit that referenced this pull request Mar 11, 2020
@MylesBorins
test: mark test-timers-blocking-callback flaky on osx
e00e77e 
This is only for 10.15 but this test is periodically failing across
many CI runs. Would like to mark this as flaky so we can avoid lots
of red CI.

Refs: #21781

PR-URL: #32189
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
MylesBorins added a commit that referenced this pull request Mar 11, 2020
@MylesBorins
test: mark test-timers-blocking-callback flaky on osx
84197ea 
This is only for 10.15 but this test is periodically failing across
many CI runs. Would like to mark this as flaky so we can avoid lots
of red CI.

Refs: #21781

PR-URL: #32189
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 11, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@MylesBorins @targos
test: mark test-timers-blocking-callback flaky on osx
0403f00 
This is only for 10.15 but this test is periodically failing across
many CI runs. Would like to mark this as flaky so we can avoid lots
of red CI.

Refs: #21781

PR-URL: #32189
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MylesBorins @gireeshpunathil @BethGriggs @nodejs-github-bot