Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: make stream.destroy with callback API public #32021

Closed
wants to merge 7 commits into from
Closed

stream: make stream.destroy with callback API public #32021

wants to merge 7 commits into from

Commits on Feb 29, 2020

  1. stream: make stream.destroy with callback API public 

    This makes the `stream.destroy(err, callback)` API public.

Additionally it makes some changes for easier use:

- The callback is always invoked with the same behavior as eos.
- The error is assumed to be handled and uncaughException is
  supressed.
- The callback timing is the same regardless whether destroy
  has already been called or not.
- The callback is always invoked asynchronously.
- The callback used be invoked before emitting 'error' and/or
  'close'.
    @ronag
    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    4d51ce2 View commit details
    Browse the repository at this point in the history

  2. fixup: docs

    @ronag
    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    54f62fc View commit details
    Browse the repository at this point in the history

  3. fixup: docs

    @ronag
    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    c020324 View commit details
    Browse the repository at this point in the history

  4. fixup: tls test + writable write complete err

    @ronag
    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    80cf7f6 View commit details
    Browse the repository at this point in the history

  5. fixup: test

    @ronag
    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    43472c4 View commit details
    Browse the repository at this point in the history

  6. fixup: reduce changes

    @ronag
    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    b40a103 View commit details
    Browse the repository at this point in the history

  7. fixup: always register eos

    @ronag
    ronag committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    81de706 View commit details
    Browse the repository at this point in the history