-
-
Couldn't load subscription status.
- Fork 33.6k
docs: replace all instances of node.js with io.js because trademark. #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we get rid of the "Evented I/O For V8 JavaScript" garbage while we're in there too? |
|
@rvagg that's already gone in the README, where else is it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this looks wrong :)
|
Do we need to s/nodejs/iojs/g too? Or only remove references to "node.js"? Not really across trademark laws. |
|
@SomeoneWeird are there instances where it makes sense to do this? We should be thorough in this unless it's too yak-shavy. @mikeal see src/res/node.rc - on current joyent/node it even shows up on the Windows process manager as "Evented I/O for V8 JavaScript" with no mention of "node", we have it fixed here and you're changing it to "io.js: Evented I/O for V8 JavaScript". I don't know what else to call it but anything would be better than that. |
ef69bad to
e36faf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can change
|
this reaches down in to npm to make changes and probably shouldn't |
d7e65ff to
185d11c
Compare
|
Yeah, I think ./deps should be ignored, doesn't really make a whole lot of sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted, it checks if the debugged file is src/node.js.
|
Okay, I'll stop repeating myself. :-) All changes to deps/ and some of the changes to src/ and test/ should be reverted. Run |
|
I'm closing this, it doesn't merge cleanly and is rife with problems. |
I doubt this is acceptable "as is" but it's a good starting point to talk about all the places the trademarked term "node.js" appears in the repo and what, in all, might need to be changed in order to remove it.