Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: Refine and unify exports resolution error handling #31625

Closed
wants to merge 9 commits into from
Closed

module: Refine and unify exports resolution error handling #31625

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
888fae1
module: "exports" resolution error handling refinements
guybedford Feb 3, 2020
e59a16e
Apply suggestions from code review
guybedford Feb 4, 2020
56269a6
linting fixest status
guybedford Feb 4, 2020
fb97d97
unabbreviate ERR_PACKAGE_PATH_NOT_EXPORTED
guybedford Feb 4, 2020
baec562
fixup json stringify
guybedford Feb 4, 2020
3685468
fixup circular ref
guybedford Feb 4, 2020
cac7c60
reinline sep
guybedford Feb 4, 2020
61c5de0
pr feedback
guybedford Feb 8, 2020
f6d4dac
fixup local checks
guybedford Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup json stringify
  • Loading branch information
@guybedford
guybedford committed Feb 4, 2020
commit baec562a4372a38d16085dc21bc66098af372621
6 changes: 3 additions & 3 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
const {
ArrayIsArray,
Error,
JSON,
JSONStringify,
Map,
MathAbs,
NumberIsInteger,
Expand Down Expand Up @@ -1091,10 +1091,10 @@ E('ERR_INVALID_PACKAGE_CONFIG',
`Invalid package config %s${sep}package.json, %s`, Error);
E('ERR_INVALID_PACKAGE_TARGET', (pkgPath, key, subpath, target) => {
if (key === '.') {
return `Invalid "exports" main target ${JSON.stringify(target)} defined ` +
return `Invalid "exports" main target ${JSONStringify(target)} defined ` +
`in the package config ${pkgPath}${sep}package.json`;
} else {
return `Invalid "exports" target ${JSON.stringify(target)} defined for '${
return `Invalid "exports" target ${JSONStringify(target)} defined for '${
StringPrototypeSlice(key, 0, -subpath.length || key.length)}' in the ` +
`package config ${pkgPath}${sep}package.json`;
}
Expand Down