Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: eslint rule making common.js mandatory #3157

Closed
wants to merge 2 commits into from
Closed

test: eslint rule making common.js mandatory #3157

wants to merge 2 commits into from

Commits on Oct 6, 2015

  1. test: load common.js in all tests 

    common.js contains code that detects leaked variables.

In preparation for an eslint rule that will enforce loading common.js in
test files, load it everywhere it can be loaded and use an
`eslint-disable` comment for files that intentionally leak.
    @Trott
    Trott committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    c2c0721 View commit details
    Browse the repository at this point in the history

  2. test: make common.js mandatory via linting rule 

    test/common.js contains code that detects global variable leaks.

This eslint rule checks that a module named `common` is loaded. It is
only applicable to files in the test directory. Tests that intentionally
leak variables can opt out with an eslint-disable comment.
    @Trott
    Trott committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    34fc281 View commit details
    Browse the repository at this point in the history