Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix minor typo in base_object.h #31535

Closed
wants to merge 1 commit into from
Closed

src: fix minor typo in base_object.h #31535

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jan 27, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 27, 2020
@danbev
Copy link
Contributor Author

danbev commented Jan 30, 2020

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4125/

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2020
danbev added a commit that referenced this pull request Jan 30, 2020
@danbev
src: fix minor typo in base_object.h
d227d22 
PR-URL: #31535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented Jan 30, 2020

Landed in d227d22.

@danbev danbev closed this Jan 30, 2020
@danbev danbev deleted the das-gc branch January 30, 2020 11:26
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@danbev @codebytere
src: fix minor typo in base_object.h
c167ae0 
PR-URL: #31535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
targos pushed a commit that referenced this pull request Apr 18, 2020
@danbev @targos
src: fix minor typo in base_object.h
3bf21b0 
PR-URL: #31535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @jasnell @Trott @addaleax @cjihrig @devnexen @nodejs-github-bot