Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update postmortem test with v12 constants #31391

Closed
wants to merge 1 commit into from
Closed

test: update postmortem test with v12 constants #31391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/v8-updates/test-postmortem-metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ const missing = getExpectedSymbols().filter((symbol) => {
return !symbols.includes(symbol);
});

assert.strictEqual(missing.length, 0, `Missing constants: ${missing}`);
assert.strictEqual(missing.length, 0,
`Missing constants: \n${missing.join('\n')}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit suggestion to get rid of a trailing space and indent the missing constants by 2 spaces in the output for easier reading:

Suggested change
`Missing constants: \n${missing.join('\n')}`);
`Missing constants:\n ${missing.join('\n ')}`);


// This is only a function so that the long list of expected symbols can be
// pushed to the bottom of the file for improved readability.
Expand All @@ -58,6 +59,7 @@ function getExpectedSymbols() {
// should only consist of postmortem constants, and some of them can be
// relatively long.
/* eslint-disable max-len */
'v8dbg_class_DescriptorArray__header_size__uintptr_t',
'v8dbg_bit_field3_is_dictionary_map_shift',
'v8dbg_bit_field3_number_of_own_descriptors_shift',
'v8dbg_class_Code__instruction_size__int',
Expand Down