[v10.x] n-api: add napi_get_all_property_names#31384
Closed
gabrielschulhof wants to merge 1 commit intonodejs:v10.x-stagingfrom
Closed
[v10.x] n-api: add napi_get_all_property_names#31384gabrielschulhof wants to merge 1 commit intonodejs:v10.x-stagingfrom
gabrielschulhof wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
nodejs-github-bot
added
c++
gabrielschulhof
added
the
semver-minor
legendecas
approved these changes
Jan 17, 2020
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
|
@gabrielschulhof would you be able to take a look at the conflicts? (I'm working on landing all of the v10.x PRs in the order in which they were opened, so it's possible the conflicts were caused by something that recently landed on v10.x-staging). |
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: nodejs#30006 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
gabrielschulhof
force-pushed
the
backport-30006-to-v10.x
branch
from
9c0b96e to
3909b7b
Compare
Contributor
Author
|
@BethGriggs rebased. Sorry about the delay! |
Collaborator
BethGriggs
approved these changes
Mar 2, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Mar 2, 2020
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #30006 Backport-PR-URL: #31384 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in ecbb331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: @gabrielschulhof
PR-URL: #30006
Reviewed-By: @addaleax
Reviewed-By: @legendecas
Reviewed-By: @gabrielschulhof
Reviewed-By: @mhdawson
Reviewed-By: @Trott
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes