Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: pipeline should use req.abort() to destroy response #31054

Closed
wants to merge 4 commits into from
Closed

stream: pipeline should use req.abort() to destroy response #31054

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6dd8500
stream: pipeline should use req.abort() to destroy response
ronag Dec 21, 2019
b7a0f75
fixup: nit
ronag Dec 21, 2019
039b944
fixup
ronag Dec 25, 2019
14c816d
Update test/parallel/test-stream-pipeline.js
ronag Dec 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: nit
  • Loading branch information
@ronag
ronag committed Dec 21, 2019
commit b7a0f753f3361071bee8ca5156ad0bb8d7ec27a0
8 changes: 2 additions & 6 deletions test/parallel/test-stream-pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,11 +496,7 @@ const { promisify } = require('util');
res.write('asd');
});
server.listen(0, function() {
http.request({
port: this.address().port,
path: '/',
method: 'GET'
}, (res) => {
http.get({ port: this.address().port }, (res) => {
const stream = new PassThrough();

stream.on('error', common.mustCall());
Expand All @@ -514,6 +510,6 @@ const { promisify } = require('util');
);

stream.destroy(new Error('oh no'));
}).end().on('error', common.mustNotCall());
}).on('error', common.mustNotCall());
});
}