doc: clarify build support text #30899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
lpinca
approved these changes
Dec 11, 2019
cjihrig
approved these changes
Dec 11, 2019
Trott
added
the
author ready
BridgeAR
approved these changes
Dec 11, 2019
gengjiawen
approved these changes
Dec 12, 2019
Revise compilation/execution support text to keep it shorter, simpler, and hopefully easier to read/understand. PR-URL: nodejs#30899 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Landed in 6143e00 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2019
Revise compilation/execution support text to keep it shorter, simpler, and hopefully easier to read/understand. PR-URL: #30899 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Revise compilation/execution support text to keep it shorter, simpler, and hopefully easier to read/understand. PR-URL: #30899 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Revise compilation/execution support text to keep it shorter, simpler, and hopefully easier to read/understand. PR-URL: #30899 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise compilation/execution support text to keep it shorter, simpler,
and hopefully easier to read/understand.
As someone else said in another PR, squinting may be required to see the difference, but I do think this is easier to read/understand.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes