move test-http-max-http-headers to parallel #30712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Trott merged 0 commits into nodejs:master from Trott:headersize

Dec 1, 2019

Member

Trott commented Nov 29, 2019

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot added the test label

This comment has been minimized.

Sign in to view

devnexen approved these changes

View reviewed changes

Contributor

devnexen left a comment •

edited

Loading

Might be unnecessary bit in the commit comment in the end :-)

Trott force-pushed the headersize branch from b4b2ff9 to 4efe37b Compare

November 29, 2019 12:58

Member Author

Trott commented Nov 29, 2019

Might be unnecessary bit in the commit comment in the end :-)

Oops, thanks, corrected!

Trott force-pushed the headersize branch from 4efe37b to f373038 Compare

November 29, 2019 13:10

Collaborator

nodejs-github-bot commented Nov 29, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27162/

lpinca approved these changes

View reviewed changes

Collaborator

nodejs-github-bot commented Nov 29, 2019 •

edited by addaleax

Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27184/ (:heavy_check_mark:)

addaleax added the author ready label

Member Author

Trott commented Dec 1, 2019

Landed in 49fb529...5b52a62

Trott added a commit to Trott/io.js that referenced this pull request


          test: remove unused callback argument

179f661

PR-URL: nodejs#30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request


          test: simplify forEach() usage

0132cdd

Use an array literal instead of using split() on a very short string.

PR-URL: nodejs#30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request


          test: remove unused callback argument

d2ea4cf

PR-URL: nodejs#30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request


          test: correct header length subtraction

05c5ebb

In test-http-max-http-headers, a comment asks why we are subtracting 32
from the length of the invalid-length-by-1 headers instead of just 1.
Subtracting 1 seems to be correct and works.

PR-URL: nodejs#30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott closed this

Trott force-pushed the headersize branch from f373038 to 5b52a62 Compare

December 1, 2019 10:44

Trott merged commit 5b52a62 into nodejs:master

targos pushed a commit that referenced this pull request


          test: remove unused callback argument

01ab031

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request


          test: simplify forEach() usage

d69b9b7

Use an array literal instead of using split() on a very short string.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request


          test: remove unused callback argument

1222be8

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request


          test: correct header length subtraction

1918b4e

In test-http-max-http-headers, a comment asks why we are subtracting 32
from the length of the invalid-length-by-1 headers instead of just 1.
Subtracting 1 seems to be correct and works.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request


          test: move test-http-max-http-headers to parallel

1e199ce

test-http-max-http-headers seems to run fine in parallel, even with
`tools/test.py -j 96 --repeat 192
test/parallel/test-http-max-http-headers.js`.

The same applies to `test-set-http-max-http-headers.js` which (as
written) depends on `test-http-max-http-headers.js` being in the same
directory. So that is being moved too.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BridgeAR mentioned this pull request

v13.3.0 proposal #30774

Merged

targos pushed a commit that referenced this pull request


          test: remove unused callback argument

804e6e4

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request


          test: simplify forEach() usage

ce11088

Use an array literal instead of using split() on a very short string.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request


          test: remove unused callback argument

e3c9e08

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request


          test: correct header length subtraction

489d333

In test-http-max-http-headers, a comment asks why we are subtracting 32
from the length of the invalid-length-by-1 headers instead of just 1.
Subtracting 1 seems to be correct and works.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BethGriggs mentioned this pull request

v12.13.2 proposal #30865

Closed

MylesBorins pushed a commit that referenced this pull request


          test: remove unused callback argument

276741a

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: simplify forEach() usage

5bb7bf3

Use an array literal instead of using split() on a very short string.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: remove unused callback argument

b37609d

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: correct header length subtraction

0b0cd8d

In test-http-max-http-headers, a comment asks why we are subtracting 32
from the length of the invalid-length-by-1 headers instead of just 1.
Subtracting 1 seems to be correct and works.

PR-URL: #30712
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BethGriggs mentioned this pull request

v12.14.1 proposal #31069

Merged

BethGriggs added the backported-to-v12.x label

Trott deleted the headersize branch

April 14, 2022 11:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready test