Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13.x] Backport update to V8 7.9 #30513

Closed
wants to merge 28 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a1a454e
deps: update V8 to 7.9.317.22
targos Nov 17, 2019
221731d
build: reset embedder string to "-node.0"
targos Nov 17, 2019
387c68e
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
3681050
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
b8d4407
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
4c39b44
deps: update V8's postmortem script
cjihrig Sep 27, 2019
b759c02
deps: update V8's postmortem script
cjihrig Oct 15, 2019
ed719e5
deps: V8: patch register-arm64.h
refack May 22, 2019
3963d0e
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
db1d9c5
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
5592f5b
deps: V8: cherry-pick f2d92ec
targos Oct 18, 2019
cd87768
deps: V8: cherry-pick 3e82c8d
targos Oct 21, 2019
46d8252
deps: V8: cherry-pick cfe9172
targos Oct 21, 2019
ec321fe
deps: V8: cherry-pick bba5f1f
targos Oct 24, 2019
5f26d51
deps: V8: cherry-pick 6b0a953
targos Oct 24, 2019
722e070
deps: V8: cherry-pick 7228ef8
targos Oct 24, 2019
e080455
deps: V8: cherry-pick 777fa98
targos Oct 28, 2019
3337633
deps: V8: backport 07ee86a5a28b
targos Oct 23, 2019
73766e8
deps: V8: backport 5e755c6ee6d3
targos Oct 31, 2019
6db7865
deps: V8: cherry-pick e5dbc95
Oct 30, 2019
204ab5f
deps: V8: cherry-pick 50031fae736f
targos Nov 4, 2019
493311b
deps: V8: cherry-pick a7dffcd767be
cclauss Nov 3, 2019
d9e7e11
build,tools: update V8 gypfiles for V8 7.9
targos Sep 11, 2019
2fb1da4
test: update test-postmortem-metadata.js
cjihrig Oct 15, 2019
65df1aa
src: update v8abbr.h for V8 update
cjihrig Oct 15, 2019
88b02e5
test: increase limit again for network space overhead test
targos Oct 23, 2019
ba985b2
src: remove custom tracking for SharedArrayBuffers
addaleax Oct 22, 2019
42b9d19
deps: patch V8 to be API/ABI compatible with 7.8 (from 7.9)
targos Nov 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick cfe9172
Original commit message:

    [wasm] Disallow interpreter move

    The MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR macro defines a defaulted move
    constructor and move-assignment operator. The {std::unique_ptr} on the
    other hand needs the contained type to be complete when instantiating
    the move assignment operator. Hence, this fails e.g. on MSVC, see
    #30020 (comment).

    It turns out that we never actually move the interpreter, so we can
    just replace the MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR by
    DISALLOW_COPY_AND_ASSIGN.

    R=ahaas@chromium.org

    Change-Id: Iba7d30243510ed9554be62b0c4c8e6f47f0c3307
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871921
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64423}

Refs: v8/v8@cfe9172

PR-URL: #30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
targos committed Nov 17, 2019
commit 46d82520f6c0e14cd7d6134358150312741919b4
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.10',
'v8_embedder_string': '-node.11',

##### V8 defaults for Node.js #####

Expand Down
4 changes: 3 additions & 1 deletion deps/v8/src/wasm/wasm-debug.cc
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ MaybeHandle<String> GetLocalName(Isolate* isolate,
}

class InterpreterHandle {
MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR(InterpreterHandle);
Isolate* isolate_;
const WasmModule* module_;
WasmInterpreter interpreter_;
Expand Down Expand Up @@ -461,6 +460,9 @@ class InterpreterHandle {
}
return local_scope_object;
}

private:
DISALLOW_COPY_AND_ASSIGN(InterpreterHandle);
};

} // namespace
Expand Down
4 changes: 2 additions & 2 deletions deps/v8/src/wasm/wasm-interpreter.h
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@ class V8_EXPORT_PRIVATE WasmInterpreter {
uint32_t ActivationFrameBase(uint32_t activation_id);
};

MOVE_ONLY_NO_DEFAULT_CONSTRUCTOR(WasmInterpreter);

WasmInterpreter(Isolate* isolate, const WasmModule* module,
const ModuleWireBytes& wire_bytes,
Handle<WasmInstanceObject> instance);
Expand Down Expand Up @@ -220,6 +218,8 @@ class V8_EXPORT_PRIVATE WasmInterpreter {
private:
Zone zone_;
std::unique_ptr<WasmInterpreterInternals> internals_;

DISALLOW_COPY_AND_ASSIGN(WasmInterpreter);
};

} // namespace wasm
Expand Down