v12.13.1 release proposal

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,8 @@
+blank_issues_enabled: false
+contact_links:
+  - name: ⁉️ Need help with Node.js?
+    url: https://github.com/nodejs/help
+    about: Please file an issue in our help repo.
+  - name: 🌐 Found a problem with nodejs.org?
+    url: https://github.com/nodejs/nodejs.org/issues/new/choose
+    about: Please file an issue in the Node.js website repo.

.mailmap

@@ -270,7 +270,10 @@ Miguel Angel Asencio Hurtado <maasencioh@gmail.com> maasencioh <maasencioh@gmail
 Mikael Bourges-Sevenier <mikeseven@gmail.com> <msevenier@motorola.com>
 Mike Kaufman <mike.kaufman@microsoft.com> <mkaufman@microsoft.com>
 Minqi Pan <pmq2001@gmail.com> P.S.V.R <pmq2001@gmail.com>
-Minwoo Jung <jmwsoft@gmail.com> JungMinu <jmwsoft@gmail.com>
+Minuk Park <parkm86@gmail.com>
+Minwoo Jung <nodecorelab@gmail.com> JungMinu <jmwsoft@gmail.com>
+Minwoo Jung <nodecorelab@gmail.com> <jmwsoft@gmail.com>
+Minwoo Jung <nodecorelab@gmail.com> <minwoo@nodesource.com>
 Miroslav Bajtoš <miroslav@strongloop.com> <miro.bajtos@gmail.com>
 Mitar Milutinovic <mitar.git@tnode.com>
 Myles Borins <myles.borins@gmail.com> <mborins@us.ibm.com>
@@ -336,6 +339,7 @@ Santiago Gimeno <santiago.gimeno@gmail.com> <santiago.gimeno@ionide.es>
 Sarah Meyer <sarahsaltrick@gmail.com> sarahmeyer <sarahsaltrick@gmail.com>
 Sartrey Lee <sartrey@163.com> sartrey <sartrey@163.com>
 Saúl Ibarra Corretgé <s@saghul.net> <saghul@gmail.com>
+Shobhit Chittora <chittorashobhit@gmail.com> <schittora@paypal.com>
 Scott Blomquist <github@scott.blomqui.st> <sblom@microsoft.com>
 Segu Riluvan <rilwan22@hotmail.com> <riluvan@gmail.com>
 Sergey Kryzhanovsky <skryzhanovsky@gmail.com> <another@dhcp199-223-red.yandex.net>
@@ -382,6 +386,7 @@ Takahiro ANDO <takahiro.ando@gmail.com>
 Tarun Batra <tarun.batra00@gmail.com> Tarun <tarun.batra00@gmail.com>
 Ted Young <ted@radicaldesigns.org>
 Teppei Sato <teppeis@gmail.com>
+Theotime Poisseau <theotime.poisseau@gmail.com>
 Thomas Hunter II <me@thomashunter.name> <tom@intrinsic.com>
 Thomas Lee <thomas.lee@shinetech.com> <tom@tom-debian.sensis.com.au>
 Thomas Reggi <thomas@reggi.com>

.travis.yml

@@ -91,3 +91,15 @@ jobs:
         - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
             bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
           fi
+
+    - name: "Find syntax errors in our Python dependencies"
+      language: python
+      python: 3.8
+      install:
+        - mv .flake8 disabled.flake8  # take the blinders off of flake8
+        - python3.8 -m pip install --upgrade pip
+        - python3.8 -m pip install flake8
+      script:
+        - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+  allow_failures:  # TODO (cclauss): remove this when dependencies are clean
+    - name: "Find syntax errors in our Python dependencies"

AUTHORS

@@ -773,7 +773,7 @@ Minqi Pan <pmq2001@gmail.com>
 Jacob Edelman <edelman.jd@gmail.com>
 Mike Atkins <mike.atkins@lanetix.com>
 hackerjs <4141095@qq.com>
-Minwoo Jung <jmwsoft@gmail.com>
+Minwoo Jung <nodecorelab@gmail.com>
 Marcin Cieślak <saper@marcincieslak.com>
 Anne-Gaelle Colom <coloma@wmin.ac.uk>
 Oleksandr Chekhovskyi <oleksandr.chekhovskyi@hansoft.com>
@@ -2653,7 +2653,6 @@ Furqan Shaikh <furqan_shaikh_1999@hotmail.com>
 Roy Sommer <roy@sommer.co.il>
 James Bunton <jbunton@atlassian.com>
 Kevin Smith <Kevin.Smith@microsoft.com>
-Minwoo Jung <minwoo@nodesource.com>
 H1Gdev <h1g.z.ouroboros+github@gmail.com>
 Julian Alimin <dmastag@yahoo.com>
 Lakshmi Swetha Gopireddy <lakshmigopireddy@in.ibm.com>
@@ -2847,5 +2846,25 @@ Levhita <levhita@gmail.com>
 claudiahdz <cghr1990@gmail.com>
 Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
 Javier Ledezma <juls0593@gmail.com>
+Marian Rusnak <4215517+marian-r@users.noreply.github.com>
+Jenia <jeniabrook@gmail.com>
+Anton Gerasimov <agerasimov@twilio.com>
+rickyes <mail@zhoumq.cn>
+Simon A. Eugster <simon.eu@gmail.com>
+TATSUNO Yasuhiro <ytatsuno.jp@gmail.com>
+Robert Jensen <rjensen@butterflynetwork.com>
+dokugo <dokugo@users.noreply.github.com>
+Jakob Krigovsky <jakob@krigovsky.com>
+Sergei Osipov <cubisto@ya.ru>
+themez <themezeng@gmail.com>
+Maria Paktiti <maria.paktiti@gmail.com>
+Unlocked <10186337+TheUnlocked@users.noreply.github.com>
+Huachao Mao <huachaomao@gmail.com>
+Lucas Pardue <lucas.pardue@bbc.co.uk>
+Nicolas Thumann <46975855+n-thumann@users.noreply.github.com>
+akitsu-sanae <akitsu.sanae@gmail.com>
+Minuk Park <parkm86@gmail.com>
+Jim Schlight <jim@inspiredware.com>
+Theotime Poisseau <theotime.poisseau@gmail.com>
 
 # Generated by tools/update-authors.js

BUILDING.md

@@ -280,6 +280,11 @@ $ ./configure
 $ make -j4
 ```
 
+If you run into a `No module named 'distutils.spawn'` error when executing
+`./configure`, please try `python3 -m pip install --upgrade setuptools` or
+`sudo apt install python3-distutils -y`.
+For more information, see https://github.com/nodejs/node/issues/30189.
+
 The `-j4` option will cause `make` to run 4 simultaneous compilation jobs which
 may reduce build time. For more information, see the
 [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html).

CHANGELOG.md

@@ -28,7 +28,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V12.md#12.13.0">12.13.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V12.md#12.13.1">12.13.1</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V12.md#12.13.0">12.13.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.12.0">12.12.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.11.1">12.11.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.11.0">12.11.0</a><br/>

COLLABORATOR_GUIDE.md

@@ -341,6 +341,9 @@ Runtime Deprecations and End-of-Life APIs (internal or public) are breaking
 changes (`semver-major`). The TSC may make exceptions, deciding that one of
 these deprecations is not a breaking change.
 
+Avoid Runtime Deprecations when an alias or a stub/no-op will suffice. An alias
+or stub will have lower maintenance costs for end users and Node.js core.
+
 All deprecations receive a unique and immutable identifier. Documentation,
 warnings, and errors use the identifier when referring to the deprecation. The
 documentation for the deprecation identifier must always remain in the API

CPP_STYLE_GUIDE.md

@@ -206,8 +206,8 @@ Use explicit comparisons to `nullptr` when testing pointers, i.e.
 
 ### Ownership and Smart Pointers
 
-* [R.20]: Use `std::unique_ptr` or `std::shared_ptr` to represent ownership
-* [R.21]: Prefer `unique_ptr` over `shared_ptr` unless you need to share
+* [R.20][]: Use `std::unique_ptr` or `std::shared_ptr` to represent ownership
+* [R.21][]: Prefer `unique_ptr` over `shared_ptr` unless you need to share
   ownership
 
 Use `std::unique_ptr` to make ownership transfer explicit. For example:
@@ -286,8 +286,8 @@ data[0] = 12345;
 
 Further reading:
 
-* [ES.48]: Avoid casts
-* [ES.49]: If you must use a cast, use a named cast
+* [ES.48][]: Avoid casts
+* [ES.49][]: If you must use a cast, use a named cast
 
 ### Using `auto`
 

Makefile

@@ -347,24 +347,6 @@ test-valgrind: all
 test-check-deopts: all
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential
 
-benchmark/napi/function_call/build/$(BUILDTYPE)/binding.node: \
-		benchmark/napi/function_call/napi_binding.c \
-		benchmark/napi/function_call/binding.cc \
-		benchmark/napi/function_call/binding.gyp | all
-	$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
-		--python="$(PYTHON)" \
-		--directory="$(shell pwd)/benchmark/napi/function_call" \
-		--nodedir="$(shell pwd)"
-
-benchmark/napi/function_args/build/$(BUILDTYPE)/binding.node: \
-		benchmark/napi/function_args/napi_binding.c \
-		benchmark/napi/function_args/binding.cc \
-		benchmark/napi/function_args/binding.gyp | all
-	$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
-		--python="$(PYTHON)" \
-		--directory="$(shell pwd)/benchmark/napi/function_args" \
-		--nodedir="$(shell pwd)"
-
 DOCBUILDSTAMP_PREREQS = tools/doc/addon-verify.js doc/api/addons.md
 
 ifeq ($(OSTYPE),aix)
@@ -470,6 +452,17 @@ test/node-api/.buildstamp: $(ADDONS_PREREQS) \
 # TODO(bnoordhuis) Force rebuild after gyp or node-gyp update.
 build-node-api-tests: | $(NODE_EXE) test/node-api/.buildstamp
 
+BENCHMARK_NAPI_BINDING_GYPS := $(wildcard benchmark/napi/*/binding.gyp)
+
+BENCHMARK_NAPI_BINDING_SOURCES := \
+	$(wildcard benchmark/napi/*/*.c) \
+	$(wildcard benchmark/napi/*/*.cc) \
+	$(wildcard benchmark/napi/*/*.h)
+
+benchmark/napi/.buildstamp: $(ADDONS_PREREQS) \
+	$(BENCHMARK_NAPI_BINDING_GYPS) $(BENCHMARK_NAPI_BINDING_SOURCES)
+	@$(call run_build_addons,"$$PWD/benchmark/napi",$@)
+
 .PHONY: clear-stalled
 clear-stalled:
 	@echo "Clean up any leftover processes but don't error if found."
@@ -599,11 +592,10 @@ test-hash-seed: all
 	$(NODE) test/pummel/test-hash-seed.js
 
 .PHONY: test-doc
-test-doc: doc-only ## Builds, lints, and verifies the docs.
+test-doc: doc-only lint ## Builds, lints, and verifies the docs.
 	@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
 		echo "Skipping test-doc (no crypto)"; \
 	else \
-		$(MAKE) lint; \
 		$(PYTHON) tools/test.py $(PARALLEL_ARGS) doctool; \
 	fi
 
@@ -1163,13 +1155,12 @@ bench: bench-addons-build
 
 # Build required addons for benchmark before running it.
 .PHONY: bench-addons-build
-bench-addons-build: benchmark/napi/function_call/build/$(BUILDTYPE)/binding.node \
-	benchmark/napi/function_args/build/$(BUILDTYPE)/binding.node
+bench-addons-build: | $(NODE_EXE) benchmark/napi/.buildstamp
 
 .PHONY: bench-addons-clean
 bench-addons-clean:
-	$(RM) -r benchmark/napi/function_call/build
-	$(RM) -r benchmark/napi/function_args/build
+	$(RM) -r benchmark/napi/*/build
+	$(RM) benchmark/napi/.buildstamp
 
 .PHONY: lint-md-rollup
 lint-md-rollup:

README.md

@@ -338,26 +338,22 @@ For information about the governance of the Node.js project, see
 **Jan Krems** <jan.krems@gmail.com> (he/him)
 * [joaocgreis](https://github.com/joaocgreis) -
 **João Reis** <reis@janeasystems.com>
-* [joshgav](https://github.com/joshgav) -
-**Josh Gavant** <josh.gavant@outlook.com>
 * [joyeecheung](https://github.com/joyeecheung) -
 **Joyee Cheung** <joyeec9h3@gmail.com> (she/her)
 * [julianduque](https://github.com/julianduque) -
 **Julian Duque** <julianduquej@gmail.com> (he/him)
 * [JungMinu](https://github.com/JungMinu) -
-**Minwoo Jung** <minwoo@nodesource.com> (he/him)
+**Minwoo Jung** <nodecorelab@gmail.com> (he/him)
 * [kfarnung](https://github.com/kfarnung) -
 **Kyle Farnung** <kfarnung@microsoft.com> (he/him)
-* [kunalspathak](https://github.com/kunalspathak) -
-**Kunal Pathak** <kunal.pathak@microsoft.com>
 * [lance](https://github.com/lance) -
 **Lance Ball** <lball@redhat.com> (he/him)
+* [legendecas](https://github.com/legendecas) -
+**Chengzhong Wu** <legendecas@gmail.com> (he/him)
 * [Leko](https://github.com/Leko) -
 **Shingo Inoue** <leko.noor@gmail.com> (he/him)
 * [lpinca](https://github.com/lpinca) -
 **Luigi Pinca** <luigipinca@gmail.com> (he/him)
-* [lucamaraschi](https://github.com/lucamaraschi) -
-**Luca Maraschi** <luca.maraschi@gmail.com> (he/him)
 * [lundibundi](https://github.com/lundibundi) -
 **Denys Otrishko** <shishugi@gmail.com> (he/him)
 * [maclover7](https://github.com/maclover7) -
@@ -430,8 +426,6 @@ For information about the governance of the Node.js project, see
 **Sakthipriyan Vairamani** <thechargingvolcano@gmail.com> (he/him)
 * [thekemkid](https://github.com/thekemkid) -
 **Glen Keane** <glenkeane.94@gmail.com> (he/him)
-* [thlorenz](https://github.com/thlorenz) -
-**Thorsten Lorenz** <thlorenz@gmx.de>
 * [TimothyGu](https://github.com/TimothyGu) -
 **Tiancheng "Timothy" Gu** <timothygu99@gmail.com> (he/him)
 * [tniessen](https://github.com/tniessen) -
@@ -479,6 +473,12 @@ For information about the governance of the Node.js project, see
 **Isaac Z. Schlueter** <i@izs.me>
 * [jhamhader](https://github.com/jhamhader) -
 **Yuval Brik** <yuval@brik.org.il>
+* [joshgav](https://github.com/joshgav) -
+**Josh Gavant** <josh.gavant@outlook.com>
+* [kunalspathak](https://github.com/kunalspathak) -
+**Kunal Pathak** <kunal.pathak@microsoft.com>
+* [lucamaraschi](https://github.com/lucamaraschi) -
+**Luca Maraschi** <luca.maraschi@gmail.com> (he/him)
 * [lxe](https://github.com/lxe) -
 **Aleksey Smolenchuk** <lxe@lxe.co>
 * [matthewloring](https://github.com/matthewloring) -
@@ -515,6 +515,8 @@ For information about the governance of the Node.js project, see
 **Stefan Budeanu** <stefan@budeanu.com>
 * [tellnes](https://github.com/tellnes) -
 **Christian Tellnes** <christian@tellnes.no>
+* [thlorenz](https://github.com/thlorenz) -
+**Thorsten Lorenz** <thlorenz@gmx.de>
 * [tunniclm](https://github.com/tunniclm) -
 **Mike Tunnicliffe** <m.j.tunnicliffe@gmail.com>
 * [vsemozhetbyt](https://github.com/vsemozhetbyt) -

benchmark/README.md

@@ -74,7 +74,7 @@ The common.js module is used by benchmarks for consistency across repeated
 tasks. It has a number of helpful functions and properties to help with
 writing benchmarks.
 
-### createBenchmark(fn, configs[, options])
+### createBenchmark(fn, configs\[, options\])
 
 See [the guide on writing benchmarks](../doc/guides/writing-and-running-benchmarks.md#basics-of-a-benchmark).
 

benchmark/fs/bench-opendir.js

@@ -0,0 +1,51 @@
+'use strict';
+
+const common = require('../common');
+const fs = require('fs');
+const path = require('path');
+
+const bench = common.createBenchmark(main, {
+  n: [100],
+  dir: [ 'lib', 'test/parallel'],
+  mode: [ 'async', 'sync', 'callback' ]
+});
+
+async function main({ n, dir, mode }) {
+  const fullPath = path.resolve(__dirname, '../../', dir);
+
+  bench.start();
+
+  let counter = 0;
+  for (let i = 0; i < n; i++) {
+    if (mode === 'async') {
+      // eslint-disable-next-line no-unused-vars
+      for await (const entry of await fs.promises.opendir(fullPath))
+        counter++;
+    } else if (mode === 'callback') {
+      const dir = await fs.promises.opendir(fullPath);
+      await new Promise((resolve, reject) => {
+        function read() {
+          dir.read((err, entry) => {
+            if (err) {
+              reject(err);
+            } else if (entry === null) {
+              resolve(dir.close());
+            } else {
+              counter++;
+              read();
+            }
+          });
+        }
+
+        read();
+      });
+    } else {
+      const dir = fs.opendirSync(fullPath);
+      while (dir.readSync() !== null)
+        counter++;
+      dir.closeSync();
+    }
+  }
+
+  bench.end(counter);
+}

benchmark/napi/ref/.gitignore

@@ -0,0 +1 @@
+build/