Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: esm: improve dual package hazard docs #30345

Closed
wants to merge 9 commits into from
Closed

doc: esm: improve dual package hazard docs #30345

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c469d4b
doc: esm: improve dual package hazard docs
GeoffreyBooth Nov 9, 2019
6526130
doc: esm: remove example from hazard section
GeoffreyBooth Nov 11, 2019
1f7b577
doc: esm: revisions per feedback
GeoffreyBooth Nov 12, 2019
c9b6df3
doc: esm: give "main" a heading, mention other entry points
GeoffreyBooth Nov 13, 2019
2637f4d
doc: esm: add intro to package entry points section
GeoffreyBooth Nov 14, 2019
4b75b64
doc: rename for clarity
GeoffreyBooth Nov 14, 2019
a0d7c99
doc: merge intro language
GeoffreyBooth Nov 14, 2019
94e85ab
doc: typo
GeoffreyBooth Nov 16, 2019
912f281
doc: typo
GeoffreyBooth Nov 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: typo 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
  • Loading branch information
@GeoffreyBooth @vsemozhetbyt
GeoffreyBooth and vsemozhetbyt authored Nov 16, 2019
commit 912f28183555cd79903eacf2ea57cb14d7139e28
2 changes: 1 addition & 1 deletion doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ This approach is appropriate for any of the following use cases:

A variant of this approach not requiring `--experimental-conditional-exports`
for consumers could be to add an export, e.g. `"./module"`, to point to an
all-ES module-syntax version the package. This could be used via `import
all-ES module-syntax version of the package. This could be used via `import
'pkg/module'` by users who are certain that the CommonJS version will not be
GeoffreyBooth marked this conversation as resolved.
Show resolved Hide resolved
loaded anywhere in the application, such as by dependencies; or if the CommonJS
version can be loaded but doesn’t affect the ES module version (for example,
Expand Down