doc: improve doc Http2Session:Timeout #30161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add line in doc/http2.md for 'timeout' event which tell readers that 'timeout' event doesn't except any arguments. Fixes: nodejs/help#877
nodejs-github-bot
added
doc
addaleax
approved these changes
Oct 29, 2019
gireeshpunathil
approved these changes
Oct 29, 2019
devnexen
approved these changes
Oct 29, 2019
trivikr
approved these changes
Oct 29, 2019
lpinca
approved these changes
Oct 29, 2019
Member
trivikr
added
the
author ready
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 31, 2019
Add line in doc/http2.md for 'timeout' event which tell readers that 'timeout' event doesn't except any arguments. Refs: nodejs/help#877 PR-URL: #30161 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
landed as 99247e7 |
targos
pushed a commit
that referenced
this pull request
Nov 5, 2019
Add line in doc/http2.md for 'timeout' event which tell readers that 'timeout' event doesn't except any arguments. Refs: nodejs/help#877 PR-URL: #30161 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
Add line in doc/http2.md for 'timeout' event which tell readers that 'timeout' event doesn't except any arguments. Refs: nodejs/help#877 PR-URL: #30161 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
Add line in doc/http2.md for 'timeout' event which tell readers that 'timeout' event doesn't except any arguments. Refs: nodejs/help#877 PR-URL: #30161 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
Add line in doc/http2.md for 'timeout' event which tell readers that 'timeout' event doesn't except any arguments. Refs: nodejs/help#877 PR-URL: #30161 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2019
Add line in doc/http2.md for 'timeout' event which tell readers that 'timeout' event doesn't except any arguments. Refs: nodejs/help#877 PR-URL: #30161 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't expect any arguments.
Fixes: nodejs/help#877
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes