Skip to content

tools: update ESLint to v6.5.1 #29785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to v6.5.1 #29785

wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Oct 1, 2019

This supplants #29759 (although it can also be rebased after that one lands if we want to go that way).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 1, 2019
@Trott
Copy link
Member Author

Trott commented Oct 1, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3949/

trivikr
trivikr approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2019
@cjihrig cjihrig mentioned this pull request Oct 1, 2019
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Oct 3, 2019

Landed in 88ef086

@Trott Trott closed this Oct 3, 2019
Trott added a commit to Trott/io.js that referenced this pull request Oct 3, 2019
@Trott
tools: update ESLint to v6.5.1
88ef086 
PR-URL: nodejs#29785
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@Trott @BridgeAR
tools: update ESLint to v6.5.1
79f6cd3 
PR-URL: #29785
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

+1 more reviewer

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott @cjihrig @devnexen @BethGriggs @BridgeAR @trivikr @ZYSzys @nodejs-github-bot