Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: check for NODE_REPL_EXTERNAL_MODULE #29778

Merged
merged 1 commit into from
Oct 11, 2019
Merged

repl: check for NODE_REPL_EXTERNAL_MODULE #29778

merged 1 commit into from
Oct 11, 2019

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Sep 30, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnek devsnek added repl Issues and PRs related to the REPL subsystem. cli Issues and PRs related to the Node.js command line interface. labels Sep 30, 2019
@devsnek
Copy link
Member Author

devsnek commented Sep 30, 2019

cc @nodejs/repl @joyeecheung @jdalton

@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 30, 2019
targos
targos reviewed Sep 30, 2019
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
@targos
Copy link
Member

targos commented Sep 30, 2019

Are there existing npm modules which would work with this option?

@devsnek
Copy link
Member Author

devsnek commented Sep 30, 2019

@targos i don't know. I'm using this change locally to test https://github.com/nodejs/repl more aggressively.

ZYSzys
ZYSzys reviewed Oct 1, 2019
View reviewed changes
lib/internal/main/repl.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25881/

cjihrig
cjihrig approved these changes Oct 7, 2019
View reviewed changes
doc/api/cli.md Show resolved Hide resolved
lib/internal/main/repl.js Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25907/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25964/

@devsnek
repl: check for NODE_REPL_EXTERNAL_MODULE
c0305af 
PR-URL: nodejs#29778
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@devsnek devsnek merged commit c0305af into nodejs:master Oct 11, 2019
@devsnek
Copy link
Member Author

devsnek commented Oct 11, 2019

landed in c0305af

@devsnek devsnek deleted the feature/external-repl branch October 11, 2019 19:35
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
targos pushed a commit that referenced this pull request Jan 8, 2020
@devsnek @targos
repl: check for NODE_REPL_EXTERNAL_MODULE
e6397aa 
PR-URL: #29778
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@molllyn1 molllyn1 mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@baby636 baby636 mentioned this pull request Nov 5, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Nov 5, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 5, 2022
Open
@kissofire kissofire mentioned this pull request Nov 5, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 25, 2022
Open
@kissofire kissofire mentioned this pull request Dec 25, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Dec 26, 2022
Open
@137717unity 137717unity mentioned this pull request Dec 26, 2022
Open
@baby636 baby636 mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Oct 1, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
@kissofire kissofire mentioned this pull request Oct 1, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 2, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Oct 2, 2023
Open
@137717unity 137717unity mentioned this pull request Oct 2, 2023
Open
@baby636 baby636 mentioned this pull request Oct 2, 2023
Open
@baby636 baby636 mentioned this pull request Jan 2, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Jan 9, 2024
Open
@kissofire kissofire mentioned this pull request Jan 9, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Jan 9, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Jan 9, 2024
Open
@137717unity 137717unity mentioned this pull request Jan 9, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 9, 2024
Open
@baby636 baby636 mentioned this pull request Jan 9, 2024
Open
@baby636 baby636 mentioned this pull request Mar 19, 2024
Open
@baby636 baby636 mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos Awaiting requested review from targos

@Trott Trott Awaiting requested review from Trott

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. repl Issues and PRs related to the REPL subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@devsnek @targos @nodejs-github-bot @Trott @cjihrig @BridgeAR @ZYSzys