-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
[v12.x backport] stream: avoid unecessary nextTick #29691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is my first backport. I don't understand what |
|
Also I don't believe I can do 9.vi? Can I? |
|
ping @BridgeAR |
f8d373c to
24286bf
Compare
|
Backport-PR-URL should contain this PR's url, so: |
|
It looks like the commit metadata from the original was lost. This should also be in the commit message: |
24286bf to
d6b5b56
Compare
d6b5b56 to
25b6b2c
Compare
|
Unrelated travis failure? |
edd7c57 to
ced89ad
Compare
|
@ronag was there a specific reason that you closed the PR? The releasers normally land the backport PRs some time before preparing the next release. Seems like it did not end up in the last release and would need another rebase. The travis failure should be ignored as long as the Node.js CI passes. |
If we are not going to emit 'close' then there is no reason to schedule it. PR-URL: nodejs#29194 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#29691
25b6b2c to
bd05183
Compare
a0974d6 to
bcd2238
Compare
Refs: #29194
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes