Skip to content

lib: expose performance interface to global object - #29432

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:performace-global
Closed

lib: expose performance interface to global object#29432
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:performace-global

Conversation

@juanarbol

@juanarbol juanarbol commented Sep 4, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@juanarbol juanarbol mentioned this pull request Sep 4, 2019
Closed
@Trott Trott added perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. performance Issues and PRs related to the performance of Node.js. semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 4, 2019
@Trott

Trott commented Sep 4, 2019

Copy link
Copy Markdown
Member

Refs: #28635

@silverwind silverwind added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 4, 2019
@silverwind

silverwind commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

Marking as semver-major as per @jasnell's recommendation. I do see possible breakage for code that tests for exsistance of global performance and that might cause issues because the implementation is not 100% conformant.

@BridgeAR

BridgeAR commented Dec 9, 2019

Copy link
Copy Markdown
Member

I am going to close this due to this comment #28635 (comment). It should be pretty straight forward to open another PR as soon as the API is not experimental anymore.
If anyone thinks this should stay open instead, please feel free to do so or to leave a comment.

@BridgeAR BridgeAR closed this Dec 9, 2019
@juanarbol

juanarbol commented Mar 27, 2020

Copy link
Copy Markdown
Member Author

Ping @BridgeAR I think Performance API is no longer experimental, should we consider re-open this PR?

@BridgeAR

BridgeAR commented Apr 8, 2020

Copy link
Copy Markdown
Member

@juanarbol I suggest to open a new PR instead. That way it's going to show up on the first page of the PRs.

@juanarbol
juanarbol deleted the performace-global branch January 19, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. performance Issues and PRs related to the performance of Node.js. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juanarbol @Trott @silverwind @BridgeAR