Closed
Conversation
Closed
Member
|
LGTM but commit logs are normally in present tense (i.e. s/added/add/). You want to discuss it at the go/no go meeting first? |
Member
Author
|
I'd rather just merge this because it's a blocker but it needs the stronly opinioned pseudo-legal-experts of the group to sign off because I'm not confident enough to shoulder the burden of this change |
rvagg
added a commit
that referenced
this pull request
Jan 13, 2015
PR-URL: #294 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Bert Belder <bertbelder@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Discussed in TC meeting 2015-01-13, merge but accept changes if better advice comes along
Member
Author
|
discussed in today's TC meeting, will merge but accept improved advice on this in the future (of course) landed in 10f84ad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since nobody else is apparently going to do it, here's my proposal, this needs to be fixed within the next couple of days.
Disclaimer: I am not a lawyer, this action is informed by discussion in #216