Skip to content

events: improve once() performance #29307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

events: improve once() performance #29307

wants to merge 1 commit into from

Conversation

@mscdex
Copy link
Contributor

@mscdex mscdex commented Aug 25, 2019

Results:

                                      confidence improvement accuracy (*)   (**)  (***)
 events/ee-once.js argc=0 n=20000000        ***     15.46 %       ±3.02% ±4.02% ±5.24%
 events/ee-once.js argc=1 n=20000000        ***     10.71 %       ±3.48% ±4.64% ±6.05%
 events/ee-once.js argc=4 n=20000000        ***     13.51 %       ±2.84% ±3.77% ±4.91%
 events/ee-once.js argc=5 n=20000000        ***     13.72 %       ±4.01% ±5.35% ±6.99%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js. labels Aug 25, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25225/

bnoordhuis
bnoordhuis approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obvious optimization is obvious (in hindsight.) ^^

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 27, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25263/

ZYSzys pushed a commit that referenced this pull request Aug 27, 2019
@mscdex
events: improve once() performance
5ba3a2c 
PR-URL: #29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@ZYSzys
Copy link
Member

ZYSzys commented Aug 27, 2019

Landed in 5ba3a2c.

@ZYSzys ZYSzys closed this Aug 27, 2019
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@mscdex @BridgeAR
events: improve once() performance
a5049c0 
PR-URL: #29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@mscdex @BridgeAR
events: improve once() performance
3bc16f9 
PR-URL: #29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees

No one assigned

Labels

events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mscdex @nodejs-github-bot @ZYSzys @bnoordhuis @jasnell @lpinca @cjihrig @trivikr