Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Aug 21, 2019

adds missing extends Http2Session for ClientHttp2Session and ServerHttp2Session

Checklist

adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 21, 2019
@trivikr
Copy link
Member Author

trivikr commented Aug 21, 2019

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 21, 2019
@trivikr trivikr self-assigned this Aug 22, 2019
@Trott
Copy link
Member

Trott commented Aug 23, 2019

Landed in 2b1bcba

@Trott Trott closed this Aug 23, 2019
Trott pushed a commit that referenced this pull request Aug 23, 2019
Adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session.

PR-URL: #29252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@trivikr trivikr deleted the extends-http2session branch August 23, 2019 20:57
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
Adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session.

PR-URL: #29252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants