[x] stream: eos avoid listeners when possible #28751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
changed the title
ronag
force-pushed
the
stream-legacy-listener
branch
2 times, most recently
from
fe38aea to
bd553ab
Compare
ronag
changed the title
|
ping @benjamingr |
mcollina
requested changes
Jul 29, 2019
ronag
force-pushed
the
stream-legacy-listener
branch
11 times, most recently
from
9482e59 to
176ef57
Compare
|
@mcollina: Not sure I understand what to unit test here? Shouldn't existing unit tests already cover this? It's just an optimisation. Shouldn't be behavioural change. |
|
You can test that those listeners are not added in that case. |
|
@mcollina As far as I can see there are no tests for end-of-stream whatsoever? Or am I missing something? |
|
the tests are in test-stream-finished.js |
This was referenced Aug 6, 2019
Closed
|
This is still waiting on the addition of the tests. |
ronag
force-pushed
the
stream-legacy-listener
branch
from
176ef57 to
e9655f8
Compare
|
@jasnell: rebased, added test and added a few more conditions |
ronag
changed the title
ronag
force-pushed
the
stream-legacy-listener
branch
2 times, most recently
from
7d65c09 to
aefa28d
Compare
mcollina
added
the
semver-major
mcollina
reviewed
Aug 22, 2019
Any particular concern I can try to address? |
|
A review from @mafintosh would help. |
ronag
force-pushed
the
stream-legacy-listener
branch
from
aefa28d to
f4b5ddb
Compare
ronag
force-pushed
the
stream-legacy-listener
branch
from
f4b5ddb to
edb7e47
Compare
|
I'm putting this on ice for now. Will re-open later. |
ronag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly improves performance and maintainability by applying legacy compat logic only when required.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes