Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: export public symbols in addons tests #28717

Closed
wants to merge 1 commit into from
Closed

test: export public symbols in addons tests #28717

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Upcoming changes to node-gyp will turn on -fvisibility=hidden on
macOS. Ensure that public symbols that are dlsym'd have default
visibility.

Refs: #28647
Refs: nodejs/node-gyp#1828

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Jul 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24498/

@Trott
Copy link
Member

Trott commented Jul 18, 2019

Relevant CI failures....I'll put a wip label on this. Feel free to remove if you think that's not appropriate.

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Jul 18, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24736/

@BridgeAR
Copy link
Member

What's the status here?

@bnoordhuis
test: export public symbols in addons tests
34af49c 
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on
macOS. Ensure that public symbols that are dlsym'd have default
visibility.

Refs: nodejs#28647
Refs: nodejs/node-gyp#1828
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28395/

@BridgeAR
Copy link
Member

@bnoordhuis this error seems related: https://ci.nodejs.org/job/node-test-commit-plinux/30299/nodes=centos7-ppcle/testReport/junit/(root)/test/node_api_test_buffer_test/

@bnoordhuis
Copy link
Member Author

I don't think that's related. The stack trace is for test/node-api/test_buffer/test.js but this PR doesn't touch files in test/node-api, only test/addons.

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Jan 12, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28403/

@Trott
Copy link
Member

Trott commented Jan 18, 2020

Landed in cc0748f

@Trott Trott closed this Jan 18, 2020
Trott pushed a commit that referenced this pull request Jan 18, 2020
@bnoordhuis @Trott
test: export public symbols in addons tests
cc0748f 
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on
macOS. Ensure that public symbols that are dlsym'd have default
visibility.

Refs: #28647
Refs: nodejs/node-gyp#1828

PR-URL: #28717
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlau
Copy link
Member

@bnoordhuis this error seems related: https://ci.nodejs.org/job/node-test-commit-plinux/30299/nodes=centos7-ppcle/testReport/junit/(root)/test/node_api_test_buffer_test/

That’s failing the same CHECK as #31061 so probably indicates the test is reusing addresses for BackingStore which is no longer allowed.

codebytere pushed a commit that referenced this pull request Feb 17, 2020
@bnoordhuis @codebytere
test: export public symbols in addons tests
0bafb5c 
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on
macOS. Ensure that public symbols that are dlsym'd have default
visibility.

Refs: #28647
Refs: nodejs/node-gyp#1828

PR-URL: #28717
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@bnoordhuis @codebytere
test: export public symbols in addons tests
2d8afb9 
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on
macOS. Ensure that public symbols that are dlsym'd have default
visibility.

Refs: #28647
Refs: nodejs/node-gyp#1828

PR-URL: #28717
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@bnoordhuis @codebytere
test: export public symbols in addons tests
642f8c0 
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on
macOS. Ensure that public symbols that are dlsym'd have default
visibility.

Refs: #28647
Refs: nodejs/node-gyp#1828

PR-URL: #28717
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielschulhof gabrielschulhof gabrielschulhof left review comments

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bnoordhuis @nodejs-github-bot @Trott @BridgeAR @richardlau @jasnell @addaleax @gabrielschulhof @cjihrig