win: backport manifest for v0.10 #2838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of 03e9352 . Original commit message: Adding a compatibility section to node.exe embedded manifest so that Node is declared explicitly compatible with Windows 8.1. Required so that os.release() can return the correct version on Windows 8.1. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx Reviewed-by: Trevor Norris <trev.norris@gmail.com>
This is a port of b0dd3bf . Original commit message: Windows 10 wasn't listed in the executable manifest. This caused problems with trying to detect Windows 10 via `os.release()`. PR-URL: nodejs#2332 Reviewed-By: Roman Reiss <me@silverwind.io>
joaocgreis
added
windows
|
LGTM, 0.12 also needs this. |
|
@silverwind working on the port, along with some other commits! Thanks for the review |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/287/ Will wait the required 72 hours and then land, unless @rvagg says this can and needs to land faster for the release. |
|
not too late, we still have work to do on the build side to even make this release possible so there's plenty of time |
orangemocha
added a commit
that referenced
this pull request
Sep 16, 2015
This is a port of 03e9352 . Original commit message: Adding a compatibility section to node.exe embedded manifest so that Node is declared explicitly compatible with Windows 8.1. Required so that os.release() can return the correct version on Windows 8.1. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx Reviewed-by: Trevor Norris <trev.norris@gmail.com> PR-URL: #2838 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
joaocgreis
pushed a commit
that referenced
this pull request
Sep 16, 2015
This is a port of b0dd3bf . Original commit message: Windows 10 wasn't listed in the executable manifest. This caused problems with trying to detect Windows 10 via `os.release()`. PR-URL: #2332 Reviewed-By: Roman Reiss <me@silverwind.io> PR-URL: #2838 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
os.release()to report correct versions.@rvagg I know it's late, but any chance of including in v0.10.41?
cc @nodejs/platform-windows