Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: move _scrypt call out of handleError funct #28318

Closed
wants to merge 5 commits into from
Closed

crypto: move _scrypt call out of handleError funct #28318

wants to merge 5 commits into from

Commits on Jun 20, 2019

  1. crypto: move _scrypt call out of handleError funct 

    This commit moves the _scrypt function call out of the handleError
function, which now only takes in an error object as its parameter.

The motivation for this is to hopefully improve readability as it was
not clear to me the first time I stepped through the code where the
actual call to _scrypt was.
    @danbev
    danbev committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    13b51d2 View commit details
    Browse the repository at this point in the history

  2. fixup! crypto: move _scrypt call out of handleError funct

    @danbev
    danbev committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    ec54953 View commit details
    Browse the repository at this point in the history

  3. crypto: move _randomBytes call out of handleError funct 

    This commit moves the _randomBytes function call out of the handleError
function, which now it takes in an error and a buf object as its
parameters.
    @danbev
    danbev committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    3b3908d View commit details
    Browse the repository at this point in the history

  4. crypto: move _pbkdf2 call out of handleError funct 

    This commit moves the _pbkdf2 function call out of the handleError
function, which now only takes in an error and a digest object as
its parameters.
    @danbev
    danbev committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    d96eff6 View commit details
    Browse the repository at this point in the history

  5. crypto: move _impl call out of handleError funct 

    This commit moves the _impl function call out of the handleError
function, which now only takes in an object as its parameter.
    @danbev
    danbev committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    247df3c View commit details
    Browse the repository at this point in the history