lib: refactor unhandled rejection deprecation warning emission#28258
Closed
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Closed
lib: refactor unhandled rejection deprecation warning emission#28258joyeecheung wants to merge 2 commits intonodejs:masterfrom
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Conversation
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
the
process
Emit the deprecation warning in the `kDefaultUnhandledRejections` case to reduce the number of branches on unhandled rejection mode - there is now only one switch case on it. Also rename `emitWarning()` to `emitUnhandledRejectionWarning()` to avoid ambiguity with `process.emitWarning()`
joyeecheung
force-pushed
the
rejection-switch
branch
from
750b7f3 to
206c735
Compare
Collaborator
Collaborator
Member
Author
|
cc @nodejs/process |
benjamingr
reviewed
Jun 18, 2019
|
|
||
| let deprecationWarned = false; | ||
| function emitDeprecationWarning() { | ||
| if (unhandledRejectionsMode === kDefaultUnhandledRejections && |
Member
There was a problem hiding this comment.
Won't this emit the warning every time rather than just once?
Also - doesn't this break the flag?
cc @BridgeAR
Member
Author
There was a problem hiding this comment.
The only call site of emitDeprecationWarning() is now L200 which is already guarded with deprecationWarned .
Also the only branch on unhandledRejectionsMode is on L180 so you can see what actions are done for each mode by simply looking at that switch instead of jumping in multiple nested functions.
benjamingr
approved these changes
Jun 18, 2019
fhinkel
approved these changes
Jun 19, 2019
Member
Author
|
Landed in 1c23b6f |
joyeecheung
added a commit
that referenced
this pull request
Jun 19, 2019
Emit the deprecation warning in the `kDefaultUnhandledRejections` case to reduce the number of branches on unhandled rejection mode - there is now only one switch case on it. Also rename `emitWarning()` to `emitUnhandledRejectionWarning()` to avoid ambiguity with `process.emitWarning()` PR-URL: #28258 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Emit the deprecation warning in the `kDefaultUnhandledRejections` case to reduce the number of branches on unhandled rejection mode - there is now only one switch case on it. Also rename `emitWarning()` to `emitUnhandledRejectionWarning()` to avoid ambiguity with `process.emitWarning()` PR-URL: #28258 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Jul 3, 2019
BridgeAR
reviewed
Jul 4, 2019
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Seems like I forgot to submit my review.
| if (!deprecationWarned) { | ||
| emitDeprecationWarning(); | ||
| deprecationWarned = true; | ||
| } |
Member
There was a problem hiding this comment.
The second if should be part of the first one. Otherwise the deprecation notice will be visible even though the user handled the rejection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit the deprecation warning in the
kDefaultUnhandledRejectionscase to reduce the number of branches on unhandled rejection mode -
there is now only one switch case on it.
Also rename
emitWarning()toemitUnhandledRejectionWarning()to avoid ambiguity with
process.emitWarning()Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes