Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x-backport] src: extract common Bind method #28222

Closed
wants to merge 1 commit into from
Closed

[v10.x-backport] src: extract common Bind method #28222

wants to merge 1 commit into from

Commits on Jun 14, 2019

  1. src: extract common Bind method 

    `TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of
functionality, so a common `Bind` was extracted to remove duplication.

Backport-PR-URL: nodejs#28222
PR-URL: nodejs#22315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    @maclover7 @BethGriggs
    maclover7 authored and BethGriggs committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    f6f25cf View commit details
    Browse the repository at this point in the history