Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: refactor ping + settings object lifetime management #28150

Closed
wants to merge 2 commits into from
Closed

http2: refactor ping + settings object lifetime management #28150

wants to merge 2 commits into from

Commits on Jun 10, 2019

  1. http2: refactor ping + settings object lifetime management 

    Have clearer ownership relations between the `Http2Ping`,
`Http2Settings` and `Http2Session` objects.

Ping and Settings objects are now owned by the `Http2Session`
instance, and deleted along with it, so neither type of object
refers to the session after it is gone.
In the case of `Http2Ping`s, that deletion is slightly delayed,
so we explicitly reset its `session_` property.

Fixes: nodejs#28088
    @addaleax
    addaleax committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    d85020b View commit details
    Browse the repository at this point in the history

  2. fixup! http2: refactor ping + settings object lifetime management

    @addaleax
    addaleax committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    2389391 View commit details
    Browse the repository at this point in the history