Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove duplicate test-child-process-execfilesync-maxBuffer.js #28139

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jun 9, 2019

In addition correct the comment about what it does.

This is produced by

mv test/parallel/test-child-process-execfilesync-maxBuffer.js test/parallel/test-child-process-execfilesync-maxbuf.js

If you use https://github.com/nodejs/node/pull/28139/files?w=1 to view the diff you can see they aren't doing anything too different.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

In addition correct the comment about what it does.
@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 9, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Jun 9, 2019

Micro-nit: Is maxBuffer perhaps the ever-so-slightly better file name part since it clearly reflects what's being tested? (Like, if someone is looking for maxBuffer tests, they might do a case-insensitive grep for filenames with maxBuffer and miss it if it's maxbuf instead?)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2019
@joyeecheung
Copy link
Member Author

@Trott There is also test-child-process-spawnsync-maxbuf.js, and a few other child process tests that do all lower-cases...I guess we should leave that to a future PR to change all these?

pull bot pushed a commit to whtiehack/node that referenced this pull request Jun 12, 2019
In addition correct the comment about what it does.

PR-URL: nodejs#28139
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@joyeecheung
Copy link
Member Author

Landed in e0fa30f

BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
In addition correct the comment about what it does.

PR-URL: #28139
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants