Skip to content

doc: resolve ambiguity in pull-requests.md #28125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: resolve ambiguity in pull-requests.md #28125

wants to merge 1 commit into from

Conversation

@rexagod
Copy link
Member

@rexagod rexagod commented Jun 7, 2019

resolved ambiguous meanings for the term body of commit message
in pull-requests.md file

Fixes: #28068

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 7, 2019
Trott
Trott reviewed Jun 8, 2019
View reviewed changes
Trott
Trott reviewed Jun 8, 2019
View reviewed changes
Trott
Trott reviewed Jun 8, 2019
View reviewed changes
@Trott
Copy link
Member

Trott commented Jun 8, 2019

Left a few suggestions but they're totally optional as they address things that are already in the document rather than things that are introduced in this pull request.

Trott
Trott reviewed Jun 9, 2019
View reviewed changes
Trott
Trott reviewed Jun 9, 2019
View reviewed changes
@rexagod @Trott
doc: clarify commit message format in pull-requests.md
c1a93fd 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: nodejs#28068
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23727/

@rexagod
Copy link
Member Author

rexagod commented Jun 16, 2019

Pinging @trivikr to approve this if all seems fine, thanks!

@Trott
Copy link
Member

Trott commented Jun 16, 2019 •
edited
Loading

Landed in 558f834

@Trott Trott closed this Jun 16, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 16, 2019
@rexagod @Trott
doc: clarify commit message format in pull-requests.md
558f834 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: nodejs#28068
PR-URL: nodejs#28125
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@rexagod @BridgeAR
doc: clarify commit message format in pull-requests.md
833d3d5 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: #28068
PR-URL: #28125
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
@rexagod @targos
doc: clarify commit message format in pull-requests.md
39b10ab 
Resolved ambiguous meanings for the term `body of commit message`
in `pull-requests.md` file,

Fixes: #28068
PR-URL: #28125
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@trivikr trivikr trivikr left review comments

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: ambiguity in pull-requests.md

4 participants

@rexagod @Trott @nodejs-github-bot @trivikr