doc: remove stability highlight for stable functions#27753
Closed
mhdawson wants to merge 2 commits intonodejs:masterfrom
Closed
doc: remove stability highlight for stable functions#27753mhdawson wants to merge 2 commits intonodejs:masterfrom
mhdawson wants to merge 2 commits intonodejs:masterfrom
Conversation
We don't have the stability functions for all stable functions, only those that were previously experimental and then when stable. Remove the stability indicator to be consistent with the rest of the functions.
Collaborator
nodejs-github-bot
added
doc
Should not have removed the stability indicator for N-API as a whole.
lpinca
approved these changes
May 17, 2019
sam-github
approved these changes
May 17, 2019
Trott
approved these changes
May 17, 2019
jasnell
approved these changes
May 18, 2019
Member
|
Landed in 4a218fd. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 20, 2019
We don't have the stability functions for all stable functions, only those that were previously experimental and then when stable. Remove the stability indicator to be consistent with the rest of the functions. PR-URL: nodejs#27753 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 20, 2019
We don't have the stability functions for all stable functions, only those that were previously experimental and then when stable. Remove the stability indicator to be consistent with the rest of the functions. PR-URL: #27753 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have the stability functions for all stable
functions, only those that were previously experimental and
then when stable. Remove the stability indicator to be
consistent with the rest of the functions.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes