src: remove util-inl.h from header files#27631
Closed
sam-github wants to merge 3 commits intonodejs:masterfrom
Closed
src: remove util-inl.h from header files#27631sam-github wants to merge 3 commits intonodejs:masterfrom
sam-github wants to merge 3 commits intonodejs:masterfrom
Conversation
Collaborator
nodejs-github-bot
added
c++
Collaborator
Collaborator
Contributor
Author
|
@joyeecheung Can you take a look at this, which I just added? I discovered that according to test_inspector_socket_server.cc, an include of node.h used to make the ContainerOf function from util-inl.h available, so simply removing it from the .h files is likely API breaking. Since its not implicitly/transitively included by node.h anymore, I think it needs to be explicitly included when NODE_WANT_INTERNALS is not defined. Perhaps I should do the same for env-inl.h? |
sam-github
force-pushed
the
remove-util-inl
branch
from
764df0c to
7b8cddf
Compare
Collaborator
jasnell
approved these changes
May 10, 2019
sam-github
force-pushed
the
remove-util-inl
branch
from
7b8cddf to
dabf771
Compare
Collaborator
Trott
approved these changes
May 12, 2019
Trott
added
the
author ready
joyeecheung
approved these changes
May 12, 2019
cjihrig
approved these changes
May 12, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but needs a rebase.
Contributor
Author
|
I'll rebase. It also can't land until I get it working portably, it seems some compiler chains we use handle inlines a bit differently. Once its building clean on all platforms I'll land (but obviously not before). |
sam-github
force-pushed
the
remove-util-inl
branch
from
dabf771 to
e0ff755
Compare
sam-github
force-pushed
the
remove-util-inl
branch
from
e0ff755 to
fe6a038
Compare
Collaborator
Its intended that *-inl.h header files are only included into the src files that call the inline methods. Explicitly include it into the files that need it.
sam-github
force-pushed
the
remove-util-inl
branch
from
fe6a038 to
9f04523
Compare
Collaborator
Contributor
Author
|
Landed in 1df3080...b6bfc19 |
sam-github
added a commit
that referenced
this pull request
May 13, 2019
PR-URL: #27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github
added a commit
that referenced
this pull request
May 13, 2019
PR-URL: #27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github
added a commit
that referenced
this pull request
May 13, 2019
Its intended that *-inl.h header files are only included into the src files that call the inline methods. Explicitly include it into the files that need it. PR-URL: #27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 14, 2019
PR-URL: #27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 14, 2019
PR-URL: #27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 14, 2019
Its intended that *-inl.h header files are only included into the src files that call the inline methods. Explicitly include it into the files that need it. PR-URL: #27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
May 21, 2019
`node.h` may only include public APIs, which `util-inl.h` is not. There does not seem to be any reason for including it, so remove it, because otherwise native addon compilation is broken due to us not shipping the `util-inl.h` header. Refs: nodejs#27631 Fixes: nodejs#27803
Closed
2 tasks
addaleax
added a commit
that referenced
this pull request
May 21, 2019
`node.h` may only include public APIs, which `util-inl.h` is not. There does not seem to be any reason for including it, so remove it, because otherwise native addon compilation is broken due to us not shipping the `util-inl.h` header. Refs: #27631 Fixes: #27803 PR-URL: #27804 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR
pushed a commit
that referenced
this pull request
May 22, 2019
`node.h` may only include public APIs, which `util-inl.h` is not. There does not seem to be any reason for including it, so remove it, because otherwise native addon compilation is broken due to us not shipping the `util-inl.h` header. Refs: #27631 Fixes: #27803 PR-URL: #27804 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, declared an unused priv argument for Initialize, so it doesn't warn on signature mismatch.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRelated to #27531