-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: move orangemocha to Collaborator Emeriti list #27626
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexis confirmed in email that that they should be moved to the Emeriti list.
Trott
added
the
meta
Issues and PRs related to the general management of the project.
label
May 9, 2019
cjihrig
approved these changes
May 9, 2019
targos
approved these changes
May 9, 2019
richardlau
approved these changes
May 9, 2019
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 9, 2019
orangemocha
approved these changes
May 9, 2019
Given Alexis's approval on this PR, I'd like to fast-track. Upvote here if you're a Collaborator and agree. Thanks. |
BridgeAR
approved these changes
May 9, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 10, 2019
Alexis confirmed in email that that they should be moved to the Emeriti list. PR-URL: nodejs#27626 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Landed in d88fcf3 |
targos
pushed a commit
that referenced
this pull request
May 10, 2019
Alexis confirmed in email that that they should be moved to the Emeriti list. PR-URL: #27626 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alexis confirmed in email that that they should be moved to
the Emeriti list.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes