Closed
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
v8 engine
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
May 8, 2019
cjihrig
approved these changes
May 8, 2019
fhinkel
approved these changes
May 9, 2019
Member
|
This seems to be failing in the v8 ci: v8-updates/test-linux-perf |
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23015/ ✅ |
Trott
added
the
author ready
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 10, 2019
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: nodejs#27615 Refs: v8/v8@7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 10, 2019
Refs: v8/v8@7.4.288.21...7.4.288.27 PR-URL: nodejs#27615 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 556de23...95c1cb4 I put the test fix commit first and the V8 update commit second so that there wasn't a commit where the test isn't robust (or at least believed to be robust). |
targos
pushed a commit
that referenced
this pull request
May 11, 2019
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: #27615 Refs: v8/v8@7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 11, 2019
Refs: v8/v8@7.4.288.21...7.4.288.27 PR-URL: #27615 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Oct 9, 2020
The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: #27615 Refs: v8/v8@7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@7.4.288.21...7.4.288.27
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes