src: refactor deprecated UVException usage in pipe-wrap.cc#27562
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
src: refactor deprecated UVException usage in pipe-wrap.cc#27562gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
gengjiawen
commented
May 4, 2019
gengjiawen
force-pushed
the
remove_deprecated
branch
from
9648401 to
a8085d7
Compare
addaleax
approved these changes
May 4, 2019
gengjiawen
force-pushed
the
remove_deprecated
branch
from
a8085d7 to
3a43cdb
Compare
Trott
approved these changes
May 5, 2019
Trott
added
the
author ready
Collaborator
antsmartian
approved these changes
May 5, 2019
cjihrig
approved these changes
May 5, 2019
Collaborator
Member
Author
Collaborator
Member
Author
|
@ZYSzys Looks like this one still failed. |
Collaborator
Contributor
|
Triggered a re-run (resume). |
Member
Author
|
test-http2-client-destroy failed due to #20750. |
Collaborator
Member
|
Landed in 07e0395 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #27562 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #27562 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes