Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: minor assert improvements #27525

Closed
wants to merge 4 commits into from

Commits on May 2, 2019

  1. assert: fix assert.fail() stack

    This makes sure the error message visible in the error stack created
    when using `assert.fail()` without any arguments or the message set
    to `undefined` or `null` as only argument.
    That was masked before due to other changes.
    BridgeAR committed May 2, 2019
    Configuration menu
    Copy the full SHA
    2f86e62 View commit details
    Browse the repository at this point in the history
  2. assert: refine assertion message

    This makes sure that the error message is more appropriate than
    before by checking closer what operator is used and which is not.
    
    It also increases the total number of lines printed to the user.
    BridgeAR committed May 2, 2019
    Configuration menu
    Copy the full SHA
    2236e8e View commit details
    Browse the repository at this point in the history
  3. assert: use less read operations

    This reduces the total amount of reads when using `assert.ok()` with
    a falsy value. That increases the read performance significantly.
    
    Also remove a comment that can not be addressed.
    BridgeAR committed May 2, 2019
    Configuration menu
    Copy the full SHA
    d993bb9 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Configuration menu
    Copy the full SHA
    1ae3571 View commit details
    Browse the repository at this point in the history