deps,test: bump googletest to 39f72ea6f5 #27231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
build
refack
added
test
|
/CC @nodejs/testing @nodejs/build-files |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
richardlau
reviewed
Apr 14, 2019
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
Apr 14, 2019
Need to verify all jobs look for the xUnit file in the same place...
|
Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3 PR-URL: nodejs#27231 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: nodejs#27231 Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 8e1e994...d66c7e3 |
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
|
@nodejs/build any reason this shouldn't be backported to 10.x and 8.x (maybe it's too late for 8.x)? The switch to cctest.xml output means our tests are running Ref: #29451 (comment) |
3 tasks
|
Decreasing need for external tools would be good, IMO, @nodejs/lts WDYT? Can this backport to 8.x and 10.x? |
No objections as long as everything still builds/passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3
Replace
./deps/gtestwith the output offuse_gtest_files.pyChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes