build: tidy up additional libraries on Windows #27138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot
added
the
build
Collaborator
addaleax
approved these changes
Apr 8, 2019
richardlau
added
the
author ready
Member
Author
|
cc @nodejs/build-files |
Collaborator
refack
approved these changes
Apr 8, 2019
cjihrig
approved these changes
Apr 8, 2019
The report functionality that depended on `Dbghelp.lib` and `Psapi.lib` are actually in `src/debug_utils.cc` and are not dependent on the report functionality being enabled. PR-URL: nodejs#27138 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 72f4a83. |
2 tasks
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report functionality that depended on
Dbghelp.libandPsapi.libare actually in
src/debug_utils.ccand are not dependent on thereport functionality being enabled.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes