tools: implement mkcodecache as an executable

[joyeecheung]

This patch splits NativeModuleLoader into two parts - a singleton
that only relies on v8 and node::Mutex and a proxy class for
the singleton (NativeModuleEnv) that provides limited access to
the singleton as well as C++ bindings for the Node.js binary.
A mkcodecache executable is then built on top of the singleton.
This makes it possible to build a Node.js binary with embedded
code cache without building itself using the code cache stub -
the cache is now initialized by NativeModuleEnv instead which
can be refactored out of the mkcodecache dependencies.

Refs: #21563

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3197

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22274/

[joyeecheung]

The idea is that we can decompose mkcodecache out of the node binary so that it's easier to complete the build integration in GYP.
In the case of cross-compilation, the next step is now only to make sure that mkcodecache can run on the simulator, instead of making sure the entire Node.js binary can run on the simulator which would be more difficult since it contains much more platform-dependent code. (See #22934 (comment))

[refack]

Test balloon based on #27108
f96ef8276e6a5cfaa000ecf4a5ea69d4aa8da5f0...bb0ffb2fcbc16f7b62f4b907263eaf591f1c90e8
https://ci.nodejs.org/job/node-test-commit/27604/

[joyeecheung]

@nodejs/build-files @nodejs/process CI is green. can I have some reviews please?

[refack]

I'm not sure the split is worth the complexity...

[joyeecheung]

I'm not sure the split is worth the complexity...

I believe it's worth it, even not for the GYP changes - this is what I would've done in hindsight, see the previous comments in NativeModuleLoader:

// This class should not depend on a particular isolate, context, or
// environment. Rather it should take them as arguments when necessary.
// The instances of this class are per-process.

It is now no longer aware of Environment but delegate that to NativeModuleEnv, so the actual dependency of NativeModuleLoader shrinks to util-inl.h and node_mutex.h, and env.h (which basically force you to link to most files) is no longer relevant.

[refack]

Resolved some comments.

[refack]

I'm not sure the split is worth the complexity...

I believe it's worth it, even not for the GYP changes - this is what I would've done in hindsight, see the previous comments in NativeModuleLoader:

I have an idea I hope will simplify this. I'll try to right a suggestion.

Anyway, my comments are non-blocking.

[joyeecheung]

I've split the refactoring into the first commit, and submitted it as #27160

[refack]

I took the rest into #27161
Minimal change-set needed is 4a2a646

[joyeecheung]

Rebased after #27160 landed, and made the progress output optional depending on NODE_DEBUG=mkcodecache so it gets less noisy when being built by default.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22410/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22423/

[joyeecheung]

CI is green. Can I have some reviews please? @nodejs/process @nodejs/build-files

[joyeecheung]

Pinging for reviews..from the GitHub suggestions, @refack and maybe @danbev

I guess this may land as part of #27161 but then it'll be me being the sole reviewer of my own patch which is kind of odd.

[refack]

I guess this may land as part of #27161 but then it'll be me being the sole reviewer of my own patch which is kind of odd.

Well I guess we cross approved each other's bits.

[refack]

Superseded by #27161

[refack]

landed in 4fd7193 (as part of #27161)