lib: use safe methods from primordials#27096
Conversation
This changes the primordials to expose built-in prototypes with their methods already uncurried. The uncurryThis function is therefore moved to the primordials. All uses of uncurryThis on built-ins are changed to import the relevant prototypes from primordials. All uses of Function.call.bind are also changed to use primordials.
nodejs-github-bot
added
the
lib / src
Co-Authored-By: targos <targos@protonmail.com>
BridgeAR
added
the
author ready
|
Does this affect performance at all? From what I can tell this does not seem to be on any path that's performance-sensitive, though. |
I don't know which one is faster between Or are you talking about the property access ( |
| if (!Reflect.getOwnPropertyDescriptor(dest, key)) { | ||
| const desc = Reflect.getOwnPropertyDescriptor(src, key); | ||
| if (typeof desc.value === 'function') { | ||
| desc.value = uncurryThis(desc.value); |
There was a problem hiding this comment.
I was talking about this, as this affect all prototype methods, not just the Function ones.
There was a problem hiding this comment.
It is already what was done manually in all the files I changed (either with call.bind or uncurryThis). This is centralizing the uncurrying to this file. If we want to use the methods safely, we have to call them without going through the prototype.
|
Landed in 112cc7c |
This changes the primordials to expose built-in prototypes with their methods already uncurried. The uncurryThis function is therefore moved to the primordials. All uses of uncurryThis on built-ins are changed to import the relevant prototypes from primordials. All uses of Function.call.bind are also changed to use primordials. PR-URL: #27096 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
6 participants
This changes the primordials to expose built-in prototypes with their
methods already uncurried.
The uncurryThis function is therefore moved to the primordials.
All uses of uncurryThis on built-ins are changed to import the relevant
prototypes from primordials.
All uses of Function.call.bind are also changed to use primordials.