_debug_agent: use readableObjectMode option for client stream

[vkurchatkin]

No description provided.

[bnoordhuis]

R=@indutny? The change LGTM but maybe there's a reason why it initializes like that.

[indutny]

LGTM, if it works!

[vkurchatkin]

Does exactly same thing: https://github.com/iojs/io.js/blob/v1.x/lib/_stream_readable.js#L43

[bnoordhuis]

@vkurchatkin Can you amend the commit log? The first line should be <= 50 characters.

[piscisaureus]

@vkurchatkin Can you also add a commit message describing the motivation for this change. Because I can't reconstruct why this is needed/nice.

[vkurchatkin]

@bnoordhuis done
@piscisaureus Just thought that since we have public API to do this it's a good idea to actually use it.

[vkurchatkin]

There other places (a lot, actually) where _readableState and _writableState are accessed. Probably something needs to be done about that

[bnoordhuis]

@vkurchatkin Are you volunteering to clean them up? :-)

[vkurchatkin]

I'm afraid it's not as simple as cleaning up. The first thing to do is to categorize all the cases and create issues. In general I see these possible resolutions (sorted by preference):

• use existing documented API to achieve the same result;
• introduce new public API;
• introduce new protected (implementor) API;
• document some parts of private state for implementors;
• do nothing.

Can start by doing this)

[chrisdickinson]

Internal streams reaching into / through ._{writ,read}ableState to manipulate fields makes changing the stream api unpleasant, and I'd love to see that cleaned up.

That said, I'm not opposed to going through that process over the course of commits cleaning up smaller transgressions one-by-one. Unless anyone has strong feelings about it, I'd like to merge this PR as-is.

We can track progress on the other places in a separate issue -- @vkurchatkin, would you like to open that up?

[vkurchatkin]

@chrisdickinson what about this PR?

[piscisaureus]

lgtm too

[chrisdickinson]

Merging as we speak.

[chrisdickinson]

Merged in 9e62ae4. Thanks! The first shots have been fired in the struggle to cleanup stream usage 💥!