Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct typo: cert.issuerCertificate #26934

Closed
wants to merge 0 commits into from
Closed

doc: correct typo: cert.issuerCertificate #26934

wants to merge 0 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 26, 2019 •
edited
Loading

  • docs incorrectly mention issuerCert, should be issuerCertificate

Fix for Commit:
a856406c2dc#diff-f6e3a86962eaf0897ab59e88b418e64fR678

Fix for PR: #24358

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@srl295 srl295 added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. labels Mar 26, 2019
@srl295 srl295 requested a review from sam-github March 26, 2019 19:57
@nodejs-github-bot
Copy link
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3062/pipeline

srl295 referenced this pull request Mar 26, 2019
@sam-github
doc: describe certificate object properties
a856406 
PR-URL: #24358
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@srl295 srl295 requested a review from bnoordhuis March 26, 2019 20:00
@srl295 srl295 self-assigned this Mar 26, 2019
sam-github
sam-github approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 27, 2019
@srl295 srl295 closed this Mar 28, 2019
@srl295 srl295 deleted the tls-doc-fix branch March 28, 2019 21:43
@srl295
Copy link
Member Author

srl295 commented Mar 28, 2019

landed in 36e5fd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@sam-github sam-github sam-github approved these changes

Assignees

@srl295 srl295

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@srl295 @nodejs-github-bot @sam-github @bnoordhuis @cjihrig @BridgeAR