Skip to content

src: apply clang-tidy performance-faster-string-find #26812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

src: apply clang-tidy performance-faster-string-find #26812

merged 1 commit into from
Mar 22, 2019

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Mar 20, 2019 •
edited by refack
Loading

rule def: https://clang.llvm.org/extra/clang-tidy/checks/performance-faster-string-find.html.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol report Issues and PRs related to process.report. labels Mar 20, 2019
@gengjiawen
Copy link
Member Author

gengjiawen commented Mar 21, 2019 •
edited
Loading

@addaleax @refack Can you review this and #26815? thanks.

@refack
Copy link
Contributor

refack commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21729/

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@gengjiawen gengjiawen mentioned this pull request Mar 21, 2019
Closed
2 tasks
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21803/

@gengjiawen @refack
src: apply clang-tidy performance-faster-string-find
86e0296 
PR-URL: nodejs#26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack refack force-pushed the clang-tidy-performance-faster-string-find branch from acf42c0 to 86e0296 Compare March 22, 2019 22:15
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@refack refack merged commit 86e0296 into nodejs:master Mar 22, 2019
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@gengjiawen @targos
src: apply clang-tidy performance-faster-string-find
579d043 
PR-URL: nodejs#26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@gengjiawen @targos
src: apply clang-tidy performance-faster-string-find
de50346 
PR-URL: #26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @refack @BridgeAR @jasnell @richardlau @nodejs-github-bot