-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add option to require 'process' to api docs #26792
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to require the 'process' module and with the upcoming support for ES Modules, importing 'process' might be the more favorable way for developers. This commit adds that option to the documentation.
Remove unnecessary word from API documentation.
Adjust paragraph to 80 character wrap limit
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
process
Issues and PRs related to the process subsystem.
labels
Mar 20, 2019
jasnell
approved these changes
Mar 21, 2019
MylesBorins
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BridgeAR
approved these changes
Mar 25, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 25, 2019
Landed in 136c805. |
danbev
pushed a commit
that referenced
this pull request
Mar 26, 2019
It is possible to require the 'process' module and with the upcoming support for ES Modules, importing 'process' might be the more favorable way for developers. This commit adds that option to the documentation. PR-URL: #26792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 26, 2019
It is possible to require the 'process' module and with the upcoming support for ES Modules, importing 'process' might be the more favorable way for developers. This commit adds that option to the documentation. PR-URL: #26792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
It is possible to require the 'process' module and with the upcoming support for ES Modules, importing 'process' might be the more favorable way for developers. This commit adds that option to the documentation. PR-URL: nodejs#26792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
It is possible to require the 'process' module and with the upcoming support for ES Modules, importing 'process' might be the more favorable way for developers. This commit adds that option to the documentation. PR-URL: #26792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
process
Issues and PRs related to the process subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to require the 'process' module and with the upcoming
support for ES Modules, importing 'process' might be the more favorable
way for developers. This commit adds that option to the documentation as suggested by @MylesBorins.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes