Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: load internal/errors eagerly in events.js and perf_hooks.js #26771

Closed
wants to merge 2 commits into from
Closed

lib: load internal/errors eagerly in events.js and perf_hooks.js #26771

wants to merge 2 commits into from

Commits on Mar 19, 2019

  1. lib: load internal/errors eagerly in events.js 

    Since `internal/errors` is loaded by many builtin modules and is
currently the first module loaded during bootstrap, it is
fine to load it eagerly. We just need to make sure
that `internal/errors` itself load other modules lazily.
    @joyeecheung
    joyeecheung committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    5ead4a0 View commit details
    Browse the repository at this point in the history

  2. lib: load internal/errors eagerly in perf_hooks.js 

    Since `internal/errors` is loaded by many builtin modules and is
currently the first module loaded during bootstrap, it is
fine to load it eagerly. We just need to make sure
that `internal/errors` itself load other modules lazily.
    @joyeecheung
    joyeecheung committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    7d4d65a View commit details
    Browse the repository at this point in the history